Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve bit editing alt #20

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Conversation

lifeinchords
Copy link
Contributor

@angelcabo : Building on your improve-bit-editing branch: Lots of refactoring, added UI buttons. : defaulting to drag for bits, and requiring a person to go into text edit mode.

Both are promising improvements to text editing, each has its pros + cons.

this branch (alt): demo PR 20

pros:

  • can easily drag all bit types, without modifier key or reaching for handles
  • easy delete, using key command, as d key isnt trapped by the form

cons:

  • text editing for one bit at a time
  • in and out of modes for saving. cant just type

your original branch : demo PR 19

pros:

  • autosave, save as you type
  • super fast/fluid to copy and paste between 2 text bits side by side

cons:

  • links arent clickable to destination, as they are seen as text. they are visualized with underline though
  • really frustrating to drag images, clicking the image itself tries to save

Outstanding todo's: https://trello.com/c/AAwflsK7/353-bit-edit-text-2nd-pass

angelcabo and others added 14 commits August 9, 2015 20:53
* bit:hover- experimenting with more minimal hover state to fit design, with diff color gradients for bit types
* bit:hover:text- only show resize during hover
* adding noselect on map
… of a crowded canvas

* bit:text:create- min width/height
…keDraggable has no trigger now

* bit:text:drag- excluding resize handle from drag
* bit:text- hide triangle resize icon by default again
* bit:text- double click to edit text, autosave on hover exit
* bit:drag- moving hover scale animations to onPress + onRelease
* map: dble click to create a bit. Goes directly into editing
* refactor: separate out text and sketch EditingIds to independent sessions vars
* refactor: $bitElement names
* bit:edit- via double click fixed
* bit:edit- via key command- commented for now
* bug: not allowing bit:edit if already editing
* bug: bit:edit: fixed bad reference to canvas.id
* bug: bit:text:edit- Draggable disable needs to be before resizable set. Resizable init was wrong.
* bit:text:edit- resize handle flush to corner
* bit:text:edit- delete UI button
* bit:text:edit- save UI button
…r) vs edit (shown once editing)

* bit:text:edit- experimenting with turning off autoscroll, scroll within a scroll doesnt feel right
* bit:image- adding delete UI icon
* activity stream: adding header icon, iterating design towards an off canvas menu
* bit:text:edit- bug:fixed resizing on edits, after first save
* bug: fixed missing param
* bit:text:edit- cancel button bypassing save correctly
* bit--hover: moved icons to centered position: aiming for buttons on edges results in often overshooting mouse
@lifeinchords lifeinchords deployed to makeparallels-pr-20 August 13, 2015 10:22 Active
@lifeinchords lifeinchords deployed to makeparallels-pr-20 August 22, 2015 17:52 Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants